maurane/logwatcher
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(classifier): 🚑️ fix classifying criteria

Browse Source 
two log entries that are consecutive and do have different error message are two different errors.
This commit is contained in:
maurane
2026-09-23 16:07:09 +02:00
parent 20ce3471b6
commit 3ddefd24e0
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/logwatcher/classifier.py
+1 -1
View File
@@ -66,7 +66,7 @@ def _is_duplicate_error(previous: LogEntry, current: LogEntry) -> bool:
and previous.mdc_server_name == current.mdc_server_name and previous.mdc_server_name == current.mdc_server_name
and previous.store_name == current.store_name and previous.store_name == current.store_name
and previous.start_time == current.start_time and previous.start_time == current.start_time
and _error_identity(previous) == _error_identity(current) and previous.error_message == current.error_message
) )
tests/test_classifier.py
+2 -2
View File
@@ -158,7 +158,7 @@ def test_classify_log_entries_merges_consecutive_duplicates():
def test_classify_log_entries_merges_same_error_name(): def test_classify_log_entries_merges_same_error_name():
"""Same error code with a different amount is still a single log entry.""" """Same error code with a different amount is two different entries."""
log_entries = parse_lines( log_entries = parse_lines(
[ [
_build_log_line( _build_log_line(
@@ -172,7 +172,7 @@ def test_classify_log_entries_merges_same_error_name():
relevant, _ = classify_log_entries(log_entries) relevant, _ = classify_log_entries(log_entries)
assert len(relevant) == 1 assert len(relevant) == 2
def test_classify_log_entries_keeps_duplicates_from_other_store_or_scan(): def test_classify_log_entries_keeps_duplicates_from_other_store_or_scan():